| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some more pg_dump refactoring |
| Date: | 2020-06-23 20:22:05 |
| Message-ID: | 9E16633B-1D36-466A-A0C6-C7EE0D139D92@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 23 Jun 2020, at 14:57, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> Here is a patch to reorganize dumpFunc() and dumpAgg() in pg_dump, similar to daa9fe8a5264a3f192efa5ddee8fb011ad9da365. Instead of repeating the almost same large query in each version branch, use one
> query and add a few columns to the SELECT list depending on the
> version. This saves a lot of duplication.
>
> I have tested this with various old versions of PostgreSQL I had available, but a bit more random testing with old versions would be welcome.
+1 from reading the patch and lightly testing it with the older versions I had
handy, and another big +1 on the refactoring to remove the duplication.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2020-06-23 20:48:25 | Curious - "logical replication launcher" (PID) existed with exit code 1 |
| Previous Message | Andres Freund | 2020-06-23 20:00:42 | Re: [HACKERS] Custom compression methods |