Re: Fix for compiler warning triggered in WinGetFuncArgInPartition()

On Oct 9 2025, at 11:28 am, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> Just curious, what compiler/version is this? I skimmed the buildfarm
>> a bit
>> but didn't find any such warnings.
>
> My warning-scraping script found
>
> arowana | 2025-10-07 04:51:16 | nodeWindowAgg.c:3723:8: warning:
> 'forward' may be used uninitialized in this function [-Wmaybe-uninitialized]
> arowana | 2025-10-07 04:51:16 | nodeWindowAgg.c:3790:8: warning:
> 'notnull_relpos' may be used uninitialized in this function [-Wmaybe-uninitialized]
> buri | 2025-10-05 21:30:13 | nodeWindowAgg.c:3723:8: warning:
> 'forward' may be used uninitialized in this function [-Wmaybe-uninitialized]
> buri | 2025-10-05 21:30:13 | nodeWindowAgg.c:3790:8: warning:
> 'notnull_relpos' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dhole | 2025-10-05 07:34:51 | nodeWindowAgg.c:3723:8: warning:
> 'forward' may be used uninitialized in this function [-Wmaybe-uninitialized]
> dhole | 2025-10-05 07:34:51 | nodeWindowAgg.c:3790:8: warning:
> 'notnull_relpos' may be used uninitialized in this function [-Wmaybe-uninitialized]
> rhinoceros | 2025-10-09 11:10:27 | nodeWindowAgg.c:3724:8: warning:
> 'forward' may be used uninitialized in this function [-Wmaybe-uninitialized]
> rhinoceros | 2025-10-09 11:10:27 | nodeWindowAgg.c:3809:2: warning:
> 'notnull_relpos' may be used uninitialized in this function [-Wmaybe-uninitialized]
> shelduck | 2025-10-09 12:14:10 | nodeWindowAgg.c:3724:6: warning:
> 'forward' may be used uninitialized in this function [-Wmaybe-uninitialized]
> shelduck | 2025-10-09 12:14:10 | nodeWindowAgg.c:3809:2: warning:
> 'notnull_relpos' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> These all seem to be RHEL7 derivatives running gcc 4.8.something.
> Since Greg saw it only for notnull_relpos, I'm guessing he's
> running something else.

GCC 14.2.1 on Fedora 42. I wonder why I didn't see the warning for
'forward' too.

> regards, tom lane

best.

-greg