Re: Ryu floating point output patch

From: Donald Dong <xdong(at)csumb(dot)edu>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Ryu floating point output patch
Date: 2019-01-19 23:59:13
Message-ID: 9CA1C652-0629-469C-8E97-602DE9D33D19@csumb.edu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On Jan 18, 2019, at 2:05 AM, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
>
> BTW, doing that in a thread about a commitfest patch confuses the
> commitfest app and cfbot (both of which think it's a new version of the
> patch under discussion), so best avoided.

Oops. Thank you. Noted.

I think the previous additional digits behavior still exist
in the latest patch. For example:

=# set extra_float_digits = 0;
SET
=# select float4in('1.123456789');
float4in
----------
1.12346
(1 row)

=# set extra_float_digits = 1;
SET
=# select float4in('1.123456789');
float4in
-----------
1.1234568
(1 row)

The extra_float_digits is increased by 1, but two digits are
added. Without the patch, it will render ' 1.123457' instead.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-01-20 00:10:59 Re: Thread-unsafe coding in ecpg
Previous Message John Naylor 2019-01-19 23:49:08 Re: WIP: Avoid creation of the free space map for small tables