| From: | "Bossart, Nathan" <bossartn(at)amazon(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, Don Seiler <don(at)seiler(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Estimating HugePages Requirements? |
| Date: | 2021-08-09 23:48:34 |
| Message-ID: | 9C7382FE-37FF-4E02-BB9F-762D8B1E0D0D@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers |
On 8/9/21, 4:05 PM, "Zhihong Yu" <zyu(at)yugabyte(dot)com> wrote:
> -extern void CreateSharedMemoryAndSemaphores(void);
> +extern Size CreateSharedMemoryAndSemaphores(bool size_only);
>
> Should the parameter be enum / bitmask so that future addition would not change the method signature ?
I don't have a strong opinion about this. I don't feel that it's
really necessary, but if reviewers want a bitmask instead, I can
change it.
Nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-08-09 23:58:53 | Re: Estimating HugePages Requirements? |
| Previous Message | Zhihong Yu | 2021-08-09 23:10:27 | Re: Estimating HugePages Requirements? |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2021-08-09 23:58:53 | Re: Estimating HugePages Requirements? |
| Previous Message | Mark Dilger | 2021-08-09 23:37:18 | Re: Another regexp performance improvement: skip useless paren-captures |