Re: ctidscan as an example of custom-scan (Re: [v9.5] Custom Plan API)

From: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
To: Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, PgHacker <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ctidscan as an example of custom-scan (Re: [v9.5] Custom Plan API)
Date: 2014-12-25 01:54:44
Message-ID: 9A28C8860F777E439AA12E8AEA7694F801098F88@BPXM15GP.gisp.nec.co.jp
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

> > On Mon, Dec 15, 2014 at 4:55 PM, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>
> wrote:
> > > I'm not certain whether we should have this functionality in contrib
> > > from the perspective of workload that can help, but its major worth
> > > is for an example of custom-scan interface.
> > worker_spi is now in src/test/modules. We may add it there as well, no?
> >
> Hmm, it makes sense for me. Does it also make sense to add a test-case to
> the core regression test cases?
>
The attached patch adds ctidscan module at test/module instead of contrib.
Basic portion is not changed from the previous post, but file locations
and test cases in regression test are changed.

Thanks,
--
NEC OSS Promotion Center / PG-Strom Project
KaiGai Kohei <kaigai(at)ak(dot)jp(dot)nec(dot)com>

Attachment Content-Type Size
pgsql-v9.5-test-ctidscan.v2.patch application/octet-stream 98.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2014-12-25 02:55:02 Re: Securing "make check" (CVE-2014-0067)
Previous Message Michael Paquier 2014-12-24 23:52:05 Re: Moving RestoreBlockImage from xlogreader.c to xlogutils.c