From: | Maxime Schoemans <maxime(dot)schoemans(at)enterprisedb(dot)com> |
---|---|
To: | Aleksander Alekseev <aleksander(at)tigerdata(dot)com> |
Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
Subject: | Re: [PATCH] Check that index can return in get_actual_variable_range() |
Date: | 2025-09-22 14:38:53 |
Message-ID: | 9A1BC418-94D4-42DA-942A-0E38383F78CB@enterprisedb.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 19 Sep 2025, at 10:20, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>
wrote:
> Yes, this is how we typically test cases like this. IMO adding a test
> module would be helpful. It can be reused for other scenarios.
Here is an updated patch set.
- 0001 is unchanged.
- 0002 contains the module that tests the correct behavior of
get_actual_variable_range for non-returning ordering indices.
It contains a copy of the btree handler function with its index-only
capabilities removed. If you apply patch 0002 on master without 0001,
you will see that the test returns an error (ERROR: no data returned
for index-only scan) as it tries to use the index in
get_actual_variable_range, which shouldn’t be the case.
Best,
Maxime Schoemans
Attachment | Content-Type | Size |
---|---|---|
v2-0001-Check-that-index-can-return-in-get_actual_variabl.patch | application/octet-stream | 1.2 KB |
v2-0002-Add-btree_noreturn-module-as-example-of-a-non-ret.patch | application/octet-stream | 11.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2025-09-22 14:53:28 | Re: Potential deadlock in pgaio_io_wait() |
Previous Message | Jonathan S. Katz | 2025-09-22 14:18:23 | Re: Having postgresql.org link to cgit instead of gitweb |