Re: pgsql: Provide overflow safe integer math inline functions.

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org,Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: pgsql: Provide overflow safe integer math inline functions.
Date: 2017-12-17 01:35:05
Message-ID: 99F06D02-BB7E-40F1-93BE-7113713F1AC0@anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On December 16, 2017 5:31:01 PM PST, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Andres Freund <andres(at)anarazel(dot)de> writes:
>> I'm not quite following. Could you check if the same happens without
>> -O2? Not because that'd be a solution, but to narrow down how this
>> happens?
>
>The committed test looks quite broken to me: it's missing some &
>operators. Not sure how that translates into failing to fail the
>configure test,

Hm, true. As you say, it doesn't explain the problem though, it's just weird int to ptr cases. Kinda seems like clang links to a different runtime during the configure tests than what's used for postgres...

Andres

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2017-12-17 01:48:32 Re: pgsql: Provide overflow safe integer math inline functions.
Previous Message Tom Lane 2017-12-17 01:31:01 Re: pgsql: Provide overflow safe integer math inline functions.

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-12-17 01:40:24 Re: PostgreSQL crashes with SIGSEGV
Previous Message Tom Lane 2017-12-17 01:31:01 Re: pgsql: Provide overflow safe integer math inline functions.