| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Higher level questions around shared memory stats |
| Date: | 2022-03-30 19:44:20 |
| Message-ID: | 999860e3-d21c-330e-eef3-215bfa5509ac@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 29.03.22 23:01, Andres Freund wrote:
>> I think what's actually most important here is the error reporting. We need
>> to make it clear, at least via log messages, that something bad has
>> happened.
> The message currently (on HEAD, but similarly on the path) is:
> ereport(pgStatRunningInCollector ? LOG : WARNING,
> (errmsg("corrupted statistics file \"%s\"",
> statfile)));
Corrupted how? How does it know? Is there a checksum, was the file the
wrong length, what happened? I think this could use more detail.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-03-30 20:00:39 | Re: refactoring basebackup.c (zstd workers) |
| Previous Message | Peter Eisentraut | 2022-03-30 19:38:59 | Re: Commitfest Update |