Re: Adding comments to help understand psql hidden queries

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Greg Sabino Mullane <htamfids(at)gmail(dot)com>
Cc: Maiquel Grassi <grassi(at)hotmail(dot)com(dot)br>, David Christensen <david+pg(at)pgguru(dot)net>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding comments to help understand psql hidden queries
Date: 2026-03-26 15:41:53
Message-ID: 999713.1774539713@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> Greg Sabino Mullane <htamfids(at)gmail(dot)com> writes:
>>> Notably, I didn't like that some of the headers said "table" and some said
>>> "relation". I made them all say "table", although you could certainly
>>> argue for the opposite.

>> I originally had "table", but then it felt weird in my testing when I was
>> describing a sequence or view it said table. So I'm a weak +1 for relation.

> My preference for "table" is likewise weak. Anyone else have an
> opinion?

[ crickets... ]

After sleeping on it and taking another look at the output, I agree
that we need to use a mix of "relation" and "table", because some of
these queries definitely apply to all kinds of pg_class entries, while
for others we must be dealing with a table (or something reasonably
table-like, such as a foreign table). I made another pass over it
to fix that, and pushed the results.

Thanks for working on this! I know it's been a long process,
but sometimes that's what it takes to get to a consensus.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2026-03-26 15:56:46 Re: Add comments about fire_triggers argument in ri_triggers.c
Previous Message vignesh C 2026-03-26 15:24:37 Re: Skipping schema changes in publication