Re: Fix tuple deformation with virtual generated NOT NULL columns

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix tuple deformation with virtual generated NOT NULL columns
Date: 2026-06-17 06:11:01
Message-ID: 998005.1781676661@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

David Rowley <dgrowleyml(at)gmail(dot)com> writes:
>> 2. I can't quite figure out the pattern in these tests for dropping vs
>> not dropping the tables at the end of the test. Many tests do DROP
>> TABLE and a large number of others don't bother. What's meant to be
>> happening here?

> I added the DROP TABLE too, as I didn't see any reason mentioned
> anywhere that they should be kept.

A very rough rule of thumb is that we leave tables around if they
might be interesting for the pg_upgrade tests (which try to upgrade
the ending state of the core regression tests).

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Previous Message Chao Li 2026-06-17 06:05:43 Fix pg_restore --no-globals SQL output for pg_dumpall archives