Re: Feature improvement of tab completion for DEALLOCATE

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: btnakamichin <btnakamichin(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Feature improvement of tab completion for DEALLOCATE
Date: 2020-09-25 05:30:37
Message-ID: 997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020/09/25 13:45, btnakamichin wrote:
> Hello!
>
> I’d like to improve the deallocate tab completion.
>
> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.

Thanks for the patch! It looks basically good, but I think it's better
to add newline just before UNION to avoid long line, as follows.

- COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
+ COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
+ " UNION SELECT 'ALL'");

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2020-09-25 05:36:44 Re: scram-sha-256 broken with FIPS and OpenSSL 1.0.2
Previous Message Peter Eisentraut 2020-09-25 05:25:39 Re: scram-sha-256 broken with FIPS and OpenSSL 1.0.2