From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal - psql - use pager for \watch command |
Date: | 2022-06-07 03:23:00 |
Message-ID: | 996255.1654572180@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Mon, May 9, 2022 at 7:07 PM Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> út 13. 7. 2021 v 19:50 odesílatel Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> napsal:
>>> ^C\watch cancelled
>>> regression=#
> Do we really need the extra text? What about just \n, so you get:
> postgres=# \watch 1
> ...blah blah...
> ^C
> postgres=#
Fine by me.
> This affects all release branches too. Should we bother to fix this
> there? For them, I think the fix is just:
If we're doing something as nonintrusive as just adding a newline,
it'd probably be OK to backpatch.
The code needs a comment about why it's emitting a newline, though.
In particular, it had better explain why that should be conditional
on !pagerpipe, because that makes no sense to me.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Kyotaro Horiguchi | 2022-06-07 03:39:38 | Re: pg_rewind: warn when checkpoint hasn't happened after promotion |
Previous Message | Thomas Munro | 2022-06-07 03:12:49 | Re: proposal - psql - use pager for \watch command |