Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> Here's my proposed fix. Great reproducer, Alexander, thanks!
I've not looked at the issue actually being fixed, but a drive-by
comment: these loops
+ for (int i = 0; i < stream->forwarded_buffers; ++i)
+ Assert(BufferGetBlockNumber(stream->buffers[stream->next_buffer_index + i]) ==
+ stream->pending_read_blocknum + i);
should be wrapped in "#ifdef USE_ASSERT_CHECKING". Maybe the
compiler is smart enough to throw away the useless looping logic
in a production build, or maybe it isn't.
regards, tom lane