Re: [HACKERS] GnuTLS support

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] GnuTLS support
Date: 2017-11-28 15:33:52
Message-ID: 99138b4b-cddc-e9ef-3c5a-bd2afda15eb8@proxel.se
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 11/28/2017 04:19 PM, Peter Eisentraut wrote:
> On 11/19/17 20:56, Michael Paquier wrote:
>>> --with-ssl=(openssl|gnutls)
>
> I'm not sure whether this is a great improvement. Why upset existing
> build and packaging scripts? The usual options style is
> --with-nameoflib. We can have separate options and error if conflicting
> combinations are specified.

We already have a precedent in --with-uuid=LIB which has the backwards
compatibility alias --with-ossp-uuid, so I think adding --with-ssl=LIB
while keeping --with-openssl as an alias is consistent with that. I also
think the code and the interface ended up pretty clean when I added
--with-ssl in my latest patch.

The only issue I see with --with-ssl is Window's config.pl which might
end up a bit ugly to support '$config->{openssl} = "path";' as a legacy
alias.

Andreas

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-11-28 15:34:48 Re: [HACKERS] SQL procedures
Previous Message Peter Eisentraut 2017-11-28 15:21:52 Re: [HACKERS] Patch: add --if-exists to pg_recvlogical