| From: | Stas Kelvich <s(dot)kelvich(at)postgrespro(dot)ru> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Logical replication ApplyContext bloat |
| Date: | 2017-05-09 19:41:26 |
| Message-ID: | 99096066-88A7-434E-B8E3-1D30116DCBD9@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 9 May 2017, at 21:53, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>
> On 5/8/17 11:26, Peter Eisentraut wrote:
>> I think it would make more sense to reset ApplyMessageContext in
>> apply_dispatch(), so that it is done consistently after every message
>> (as the name implies), not only some messages.
>
> Committed that.
>
>> Also, perhaps ApplyMessageContext should be a child of
>> TopTransactionContext. (You have it as a child of ApplyContext, which
>> is under TopMemoryContext.)
>
> Left that as is.
Thanks!
Stas Kelvich
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2017-05-09 19:51:58 | Re: CTE inlining |
| Previous Message | Tom Lane | 2017-05-09 19:36:42 | Re: CTE inlining |