From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
Cc: | Ilya Gladyshev <ilya(dot)v(dot)gladyshev(at)gmail(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: optimizing pg_upgrade's once-in-each-database steps |
Date: | 2024-09-09 21:20:28 |
Message-ID: | 99090248-9EE7-4DA3-AC78-4F46337BD183@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 9 Sep 2024, at 21:17, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Thu, Sep 05, 2024 at 01:32:34PM +0200, Daniel Gustafsson wrote:
>> I've read and tested through the latest version of this patchset and I think
>> it's ready to go in.
>
> Thanks for reviewing. I'm aiming to commit it later this week.
+1. Looking forward to seeing what all the pg_dump/pg_upgrade changes amount
to in speed improvement when combined.
>> The one concern I have is that tasks can exit(1) on libpq
>> errors tearing down perfectly functional connections without graceful shutdown.
>> Longer term I think it would make sense to add similar exit handler callbacks
>> to the ones in pg_dump for graceful cleanup of connections. However, in order
>> to keep goalposts in clear view I don't think this patch need to have it, but
>> it would be good to consider once in.
>
> This did cross my mind. I haven't noticed any problems in my testing, and
> it looks like there are several existing places in pg_upgrade that call
> pg_fatal() with open connections, so I'm inclined to agree that this is a
> nice follow-up task that needn't hold up this patch set.
It could perhaps be a good introductory task for a new contributor who want a
fairly confined project to hack on.
--
Daniel Gustafsson
From | Date | Subject | |
---|---|---|---|
Next Message | Masahiko Sawada | 2024-09-09 21:20:44 | Re: Pgoutput not capturing the generated columns |
Previous Message | Laurenz Albe | 2024-09-09 21:14:30 | Re: Wrong security context for deferred triggers? |