RE: Determine parallel-safety of partition relations for Inserts

Hi,

I notice the comment 5) about is_parallel_possible_for_modify() seems to be inaccurate in clauses.c.
* 5) the reloption parallel_dml_enabled is not set for the target table

Because you have set parallel_dml_enabled to 'true' as default.
{
{
"parallel_dml_enabled",
"Enables \"parallel dml\" feature for this table",
RELOPT_KIND_HEAP | RELOPT_KIND_PARTITIONED,
ShareUpdateExclusiveLock
},
true
}

So even user doesn't set parallel_dml_enabled explicit, its value is 'on', Parallel is also possible for this rel(when enable_parallel_dml is on).

Maybe we can just comment like this or a better one you'd like if you agree with above:
* 5) the reloption parallel_dml_enabled is set to off

Regards
Huang

> -----Original Message-----
> From: Hou, Zhijie <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>
> Sent: Wednesday, February 3, 2021 9:01 AM
> To: Greg Nancarrow <gregn4422(at)gmail(dot)com>
> Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>; PostgreSQL Hackers
> <pgsql-hackers(at)lists(dot)postgresql(dot)org>; vignesh C <vignesh21(at)gmail(dot)com>;
> Amit Langote <amitlangote09(at)gmail(dot)com>; David Rowley
> <dgrowleyml(at)gmail(dot)com>; Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>; Tsunakawa,
> Takayuki/綱川 貴之 <tsunakawa(dot)takay(at)fujitsu(dot)com>
> Subject: RE: Determine parallel-safety of partition relations for Inserts
>
> Hi,
>
> Attaching v5 patches with the changes:
> * rebase the code on the greg's latest parallel insert patch
> * fix some code style.
>
> Please consider it for further review.
>
> Best regards,
> Houzj
>
>
>
>