| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: assorted code cleanup |
| Date: | 2017-09-07 18:00:18 |
| Message-ID: | 98ba2e15-250b-8bce-fa4c-777e0d76cd4e@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 9/5/17 15:32, Tom Lane wrote:
> At one time there were C compilers that only accepted the former syntax.
Correct. Explanation here: http://c-faq.com/ptrs/funccall.html
> I do agree with the idea that we should use the * notation in cases where
> the reader might otherwise think that a plain function was being invoked,
> ie I don't like
>
> some_function_pointer(args);
>
> Even if the compiler isn't confused, readers might be. But in the case of
>
> structname->pointerfield(args);
>
> it's impossible to read that as a plain function call, so I'm okay with
> dropping the extra punctuation there.
Committed that way. Thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-09-07 18:07:04 | Re: [bug fix] Savepoint-related statements terminates connection |
| Previous Message | Pavel Stehule | 2017-09-07 17:49:53 | Re: Re: issue: record or row variable cannot be part of multiple-item INTO list |