Re: gcc 4.6 -Wunused-but-set-variable

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gcc 4.6 -Wunused-but-set-variable
Date: 2011-06-15 23:28:53
Message-ID: 9895.1308180533@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> I couldn't see a way good way of programming around this (perhaps in the
> second case, but it would get uselessly ugly), so perhaps just marking
> the variables as potentially unused would be appropriate? See patch.

Of course this would break not only on non-gcc compilers, but old
versions of gcc. I'd suggest a macro (cf PERL_UNUSED_DECL) and some
version checks at the site of the macro declaration (perhaps the ones
emitted by bison for its use of this construct will do).

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-06-15 23:32:29 Re: creating CHECK constraints as NOT VALID
Previous Message Tom Lane 2011-06-15 23:24:19 Re: Strict Set Returning Functions