| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Build warning with meson and dtrace on Fedora 43 |
| Date: | 2026-07-30 00:33:05 |
| Message-ID: | 988760.1785371585@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrey Rachitskiy <pl0h0yp1(at)gmail(dot)com> writes:
> I've
> rewritten the probes.d note along those lines and kept ssize_t/size_t
> for the smgr probes (system-supplied, matching md.c).
> Updated patch attached.
Pushed with minor additional comment-smithing. I also double-checked
that macOS's current behavior applies at least as far back as
macOS 14 (Sonoma), so we should be good on any version that anyone
is likely to install PG 20 on.
I noticed that we had
#define bool unsigned char
in there, and tried to get rid of that, reasoning that now that we
use <stdbool.h> "bool" does not mean "unsigned char". However, macOS
rejects "bool", so I desisted. Thinking twice, it looks like we
could instead do
#define bool _Bool
but that seems like a matter for a separate patch, perhaps.
BTW, I realized that we had no buildfarm coverage of --enable-dtrace
on macOS, so I've enabled that on indri.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Neil Chen | 2026-07-30 00:45:39 | Re: [PATCH v2] Don't stop a `vacuumdb --all` on a connection failure |
| Previous Message | Quan Zongliang | 2026-07-30 00:13:01 | Re: [PATCH] Remove unused include from analyze.c |