Re: Fix for REFRESH MATERIALIZED VIEW ownership error message

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Date: 2018-08-18 21:30:28
Message-ID: 987F9F3C-6578-4A06-9E0B-FE73F22B7DE7@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


> On Aug 18, 2018, at 5:26 PM, David G. Johnston <david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
>
> On Saturday, August 18, 2018, Jonathan S. Katz <jkatz(at)postgresql(dot)org <mailto:jkatz(at)postgresql(dot)org>> wrote:
> It’s cosmetic, but it’s a cosmetic bug: it incorrectly tells the user that they
> must be the owner of the “relational” when in reality it’s the materialized view.
>
> Materialized views are a type of relation so it is not wrong, just one of many instances where we generalize to "relation" based in implementation details ins team of being explicit about which type of relation is being affected.

Sure, that’s technically correct, but it’s still confusing to a user,
particularly in this cased since the error comes from running
"REFRESH MATERIALIZED VIEW" which is only applied to materialized views.

For instance, if you try running the command on a table:

CREATE TABLE a (x int);
REFRESH MATERIALIZED VIEW a;
ERROR: "a" is not a materialized view

which is what you would and should expect.

Jonathan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Cramer 2018-08-18 21:37:59 Re: Fix for REFRESH MATERIALIZED VIEW ownership error message
Previous Message David G. Johnston 2018-08-18 21:26:06 Re: Fix for REFRESH MATERIALIZED VIEW ownership error message