| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Bruce Momjian <bruce(at)momjian(dot)us> |
| Subject: | Re: pgindent run coming |
| Date: | 2009-06-13 13:57:59 |
| Message-ID: | 9862.1244901479@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Peter Eisentraut wrote:
>> On Wednesday 10 June 2009 23:54:41 Tom Lane wrote:
>>> At a quick look, I'm not sure that any of these are in code that hasn't
>>> been edited since the 8.3 pgindent run.
>>
>> So what does that mean then? Surely pgindent doesn't keep track of what has
>> been edited when?
> If the code has been edited since the last pgindent run, then pgindent
> hasn't had a chance to adjust it, no?
Right. Those extra spaces all represent manual editing sloppiness.
I have not done a complete check, but I looked at the first couple of
examples you cited and verified that pgindent did remove those spaces.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2009-06-13 15:10:21 | Re: some of the datatypes only support hashing, while others only support sorting |
| Previous Message | Andrew Dunstan | 2009-06-13 13:33:59 | Re: pgindent run coming |