Re: Portal->commandTag as an enum

Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> writes:
>> On Feb 28, 2020, at 3:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Is there a way to drop that logic altogether by making the tagname string
>> be "INSERT 0" for the INSERT case? Or would the zero bleed into other
>> places where we don't want it?

> In general, I don't think we want to increase the number of distinct
> tags. Which command you finished running and whether you want a
> rowcount and/or lastoid are orthogonal issues.

Well, my thought is that last_oid is gone and it isn't ever coming back.
So the less code we use supporting a dead feature, the better.

If we can't remove the special case in EndCommand() altogether, I'd be
inclined to hard-code it as "if (tag == CMDTAG_INSERT ..." rather than
expend infrastructure on treating last_oid as a live option for commands
to have.

regards, tom lane