Re: get rid of Pointer type, mostly

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: David Geier <geidav(dot)pg(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: get rid of Pointer type, mostly
Date: 2025-11-24 19:15:13
Message-ID: 985179.1764011713@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Nov 24, 2025 at 1:46 PM David Geier <geidav(dot)pg(at)gmail(dot)com> wrote:
>> The GIN code makes use of pointer but src/backend/access/gin only has 29
>> occurrences. If you like I can help out fixing up the GIN code and share
>> a page here. Let me know.

> I'd go for it! I mean, who knows whether your patch will be accepted?
> But another pair of eyes couldn't hurt. It seems like we all agree
> that a full removal of Pointer would be better than a partial removal;
> it's just a question of whether we can get there without too much
> other awkwardness.

If there are actually places in GIN where using void* would be less
readable than using Pointer, that would certainly be interesting
information. Perhaps the patch would need to spend some effort
on adding comments, not just mechanically replacing the typedef?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-11-24 19:30:25 Re: Assertion failure in SnapBuildInitialSnapshot()
Previous Message Robert Haas 2025-11-24 19:05:14 Re: get rid of Pointer type, mostly