Re: allow segment size to be set to < 1GiB

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: allow segment size to be set to < 1GiB
Date: 2022-11-17 14:58:48
Message-ID: 984ba7d4-d83c-45e6-60e3-75bea792dbf5@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 2022-11-09 We 15:25, Andres Freund wrote:
> Hi,
>
> On 2022-11-09 14:44:42 -0500, Tom Lane wrote:
>> Andres Freund <andres(at)anarazel(dot)de> writes:
>>> A second question: Both autoconf and meson print the segment size as GB right
>>> now. Obviously that'll print out a size of 0 for a segsize < 1GB.
>>> The easiest way to would be to just display the number of blocks, but that's
>>> not particularly nice.
>> Well, it would be fine if you'd written --with-segsize-blocks, wouldn't
>> it? Can we make the printout format depend on which switch was used?
> Not sure why I didn't think of that...
>
> Updated patch attached.
>
> I made one autoconf and one meson CI task use a small block size, but just to
> ensure it work on both. I'd probably leave it set on one, so we keep the
> coverage for cfbot?
>

Are we going to impose some sane minimum, or leave it up to developers
to discover that for themselves?

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-11-17 15:00:11 Re: libpq support for NegotiateProtocolVersion
Previous Message Tomas Vondra 2022-11-17 14:34:16 Re: Hash index build performance tweak from sorting