| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, filip(at)jirsak(dot)org, PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #13810: cursor_to_xml ignores tableforest parameter |
| Date: | 2017-05-08 14:26:55 |
| Message-ID: | 98491633-1616-7e28-7eb1-1e8d1ef93831@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 5/5/17 15:01, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>>>> You're right, this should have a <table>...</table> around it, like
>>>> query_to_xml() does.
>
>> I have applied a fix for this to master. I'll let the build farm take
>> it for a spin and then apply it to the backbranches.
>
> I think this is missing an update for the documentation. Section 9.14.4
> describes the wrapping nodes as being <tablename> --- don't we want that
> to match reality a bit better?
It also says "If no table name is available, that is, when mapping a
query or a cursor, the string `table` is used in the first format, `row`
in the second format.", so I think it's correct and complete. (Could
have more examples perhaps, but not critical to bug fix backpatch.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-05-08 14:30:21 | Re: BUG #13810: cursor_to_xml ignores tableforest parameter |
| Previous Message | Vitaliy Gomenyuk | 2017-05-08 13:22:31 | Re: BUG #14635: Query is executed slower on hot standby slave database then on master database |