From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Noah Misch <noah(at)leadboat(dot)com> |
Cc: | pgsql-hackers(at)postgreSQL(dot)org |
Subject: | Re: More on the libxml2 update situation |
Date: | 2015-12-12 02:38:12 |
Message-ID: | 9849.1449887892@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Fri, Dec 11, 2015 at 10:55:40AM -0500, Tom Lane wrote:
>> I'm starting to think that maybe we'd better knuckle under and provide
>> a variant expected file that matches this behavior. We're likely to be
>> seeing it in the wild for some time to come.
> I would look at handling this by suppressing the exact error message from the
> output.
I had actually thought a little bit about whether we could put back the
missing output, along the lines of "if it's a syntax-type error and no
error cursor was supplied, assume we should put a cursor at end of input".
It might be worth pursuing if Veillard indicates an unwillingness to
change libxml2 going forward, because a syntax error with no location
can be pretty unfriendly. But I'll wait to see some response from him
before expending a lot of energy here.
> A variant expected output would be okay, though.
I pushed a set of those an hour ago. I hope it's just a short-term
hack, but we'll see. In any case there were now two buildfarm critters
failing, reinforcing the idea that this behavior is spreading.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Joshua D. Drake | 2015-12-12 03:03:48 | Re: Disabling an index temporarily |
Previous Message | Noah Misch | 2015-12-12 02:37:45 | Re: Re: In-core regression tests for replication, cascading, archiving, PITR, etc. |