Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Gregory Stark <stark(at)enterprisedb(dot)com>
Cc: "Zoltan Boszormenyi" <zb(at)cybertec(dot)at>, pgsql-patches(at)postgresql(dot)org, "Hans-Juergen Schoenig" <hs(at)cybertec(dot)at>
Subject: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1
Date: 2008-04-21 00:36:46
Message-ID: 9849.1208738206@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Gregory Stark <stark(at)enterprisedb(dot)com> writes:
> 4) Your problems with tsearch and timestamp etc raise an interesting problem.
> We don't need to mark this in pg_control because it's a purely a run-time
> issue and doesn't affect on-disk storage.

Just for the record, that's wrong. It's true that on-disk data isn't
affected, but the system catalog contents are, and they'd better match
what the postgres binary is going to do.

> However it does affect ABI
> compatibility with modules. Perhaps it should be added to
> PG_MODULE_MAGIC_DATA.

Very good point, especially now that it's configurable. Included
in committed patch.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Guillaume Smet 2008-04-21 04:51:25 Re: float4/float8/int64 passed by value with tsearch fixup
Previous Message Tom Lane 2008-04-21 00:28:19 Re: float4/float8/int64 passed by value with tsearch fixup