| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-09-27 14:03:51 |
| Message-ID: | 983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Thomas,
On 9/18/18 9:48 PM, Thomas Munro wrote:
> It certainly wouldn't hurt... but more pressing to get this committed
> would be Windows support IMHO. I think the thing to do is to open
> files with the FILE_FLAG_OVERLAPPED flag, and then use ReadFile() and
> WriteFile() with an LPOVERLAPPED struct that holds an offset, but I'm
> not sure if I can write that myself. I tried doing some semi-serious
> Windows development for the fsyncgate patch using only AppVeyor CI a
> couple of weeks ago and it was like visiting the dentist.
>
Sorry, no idea about this. Maybe Magnus can provide some feedback ?
> On Thu, Sep 6, 2018 at 6:42 AM Jesper Pedersen
>> Once resolved the patch passes make check-world, and a strace analysis
>> shows the associated read()/write() have been turned into
>> pread64()/pwrite64(). All lseek()'s are SEEK_END's.
>
> Yeah :-)
Thanks for v5 too.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2018-09-27 14:08:31 | Re: Problem while setting the fpw with SIGHUP |
| Previous Message | Jesper Pedersen | 2018-09-27 13:59:50 | Re: Index Skip Scan |