From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Cc: | Greg Smith <greg(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Ragged latency log data in multi-threaded pgbench |
Date: | 2010-03-23 08:37:33 |
Message-ID: | 9837222c1003230137l35583149jdb4d75173d4989ae@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 23, 2010 at 05:10, Takahiro Itagaki
<itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> wrote:
>
> Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>
>> By the way: the pgbench.sgml that you committed looks like it passed
>> through a system that added a CR to every line in it. Probably not the
>> way you intended to commit that.
>
> Oops, fixed. Thanks.
My guess is that this happened because you committed from Windows?
I learned the hard way that this is a bad idea. (Luckily I learned it
on other CVS projects, before I started committing to PostgreSQL).
There are settings to make it not do that, but they are not reliable.
I'd strongly suggest that you always just do a cvs diff on windows and
then use a staging machine running linux or bsd or something to apply
it through. And then you *always* run those patches through something
like "fromdos". It's a bunch of extra steps, but it's really the only
way to do it reliably.
If that's not at all what happened, then well, it's still good advice
I think, even if it doesn't apply :-)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2010-03-23 08:54:51 | Re: Proposal: access control jails (and introduction as aspiring GSoC student) |
Previous Message | Daniel Farina | 2010-03-23 08:20:21 | Re: Windowing Qual Pushdown |