Re: pgsql: Un-break pg_dump for the case of zero-column tables.

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Un-break pg_dump for the case of zero-column tables.
Date: 2010-02-24 07:11:34
Message-ID: 9837222c1002232311t22a1349fq7d6ceb892a57716@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

2010/2/24 Tom Lane <tgl(at)postgresql(dot)org>:
> Log Message:
> -----------
> Un-break pg_dump for the case of zero-column tables.
>
> This was evidently broken by the CREATE TABLE OF TYPE patch.  It would have
> been noticed if anyone had bothered to try dumping and restoring the
> regression database ...

Is there a point in doing that at the end of "make check"? Or as a
separate step on the buildfarm?

It would at least find problems that cause syntax errors or such
things when loading, even if we don't compare the full data?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2010-02-24 07:31:25 Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.
Previous Message Heikki Linnakangas 2010-02-24 06:30:27 Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2010-02-24 07:31:25 Re: [COMMITTERS] pgsql: Move documentation of all recovery.conf option to a new chapter.
Previous Message Greg Stark 2010-02-24 07:09:23 Re: Directory fsync and other fun