Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH]

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alex Hunsaker <badalex(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tim Bunce <Tim(dot)Bunce(at)pobox(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH]
Date: 2010-02-03 07:11:16
Message-ID: 9837222c1002022311u5105e79cu27a6b8e2ea747f66@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wednesday, February 3, 2010, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Alex Hunsaker <badalex(at)gmail(dot)com> writes:
>> On Tue, Feb 2, 2010 at 21:38, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Alex Hunsaker <badalex(at)gmail(dot)com> writes:
>>>> Yeah the both is gross.  How about:
>>>> plperl.on_plperl_init
>>>> plperl.on_plperlu_init
>>>> plperl.on_init ?
>>>
>>> I like the first two.  The problem of selecting a good name for the
>>> third one is easily solved: don't have it.  What would it be except
>>> a headache and a likely security problem?
>
>> Well its already in.
>
> Well *that's* easily fixed.  I think it's a bad idea, because it's
> unclear what you should put there and what the security implications
> are.  Two entirely separate init strings seems much easier to understand
> and administer.
>

+1.

It's a simple copy/paste in the config file if you want them the same
anyway, right?

/Magnus

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2010-02-03 07:23:04 Re: Streaming replication and SSL
Previous Message Tom Lane 2010-02-03 06:23:13 Re: BUG #5304: psql using conninfo fails in connecting to the server