From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Define INADDR_NONE on Solaris when it's missing. |
Date: | 2010-02-02 19:10:26 |
Message-ID: | 9837222c1002021110i7864d5catd42ca670baa93110@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
2010/2/1 Magnus Hagander <magnus(at)hagander(dot)net>:
> 2010/1/28 Magnus Hagander <magnus(at)hagander(dot)net>:
>> On Thu, Jan 28, 2010 at 21:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>>>> On Thu, Jan 28, 2010 at 17:16, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>>> However, now that I know the real issue is you're using inet_addr, I
>>>>> would like to know why you're not using inet_aton instead; or even
>>>>> better, something that also copes with IPv6.
>>>
>>>> "Path of least resistance?"
>>>
>>>> Which method would you suggest?
>>>
>>> I haven't actually read the RADIUS patch, but generally we rely on
>>> pg_getaddrinfo_all to interpret strings representing IP addresses.
>>> Is there a reason not to use that?
>>
>> I don't think so. I'll look it over.
>
> Here's what I came up with. Works well on the platforms I've tried,
> but I haven't tried on a non-ipv6 capable one yet (need to find one..)
> I'll also remove the defines from solaris.h when applying it.
Applied with some adjustments needed for non-ipv6 platforms.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-02-02 19:12:29 | pgsql: CLUSTER specified the wrong namespace when renaming toast tables |
Previous Message | Magnus Hagander | 2010-02-02 19:09:37 | pgsql: Make RADIUS authentication use pg_getaddrinfo_all() to get |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2010-02-02 19:16:17 | Re: New VACUUM FULL crashes on temp relations |
Previous Message | Andres Freund | 2010-02-02 19:08:12 | Re: [HACKERS] Re: Faster CREATE DATABASE by delaying fsync (was 8.4.1 ubuntu karmic slow createdb) |