Re: pgsql: Define INADDR_NONE on Solaris when it's missing.

On Thu, Jan 28, 2010 at 17:04, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Thu, Jan 28, 2010 at 16:46, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Possibly more to the point, where are we using INADDR_NONE anyway?
>
>> In the RADIUS code.
>
> Oh, that's why it isn't in my tree and has zero portability track record ...
>
> I think what this shows is we should look for a way to avoid using
> INADDR_NONE.  What's your grounds for believing it's portable at all?
> In the Single Unix Spec I only see INADDR_ANY and INADDR_BROADCAST
> defined.

Um, I don't think I have any specific grounds for it, other than
having seen it in a lot of other software :-)

From some more googling
(http://www.opengroup.org/onlinepubs/000095399/functions/inet_addr.html),
it says it will return (in_addr_t)(-1), though, so maybe we should
just move that #ifdef out to some global place?

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/