From: | Magnus Hagander <magnus(at)hagander(dot)net> |
---|---|
To: | Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Windows x64 [repost] |
Date: | 2010-01-01 19:45:44 |
Message-ID: | 9837222c1001011145i35bb5909y297a2a662ddd8e10@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> wrote:
>
> 2) use appropriate macro and datatypes for Windows API.
> enables more than 32bits shared memory.
Are you sure this one should use __noop, and not __nop?
__noop: http://msdn.microsoft.com/en-us/library/s6btaxcs.aspx
__nop: http://msdn.microsoft.com/en-us/library/aa983381.aspx
I think __nop is what we want?
Also, that turns it into "nop" and not "rep nop", no?
Should we perhaps instead use __yield, per:
http://msdn.microsoft.com/en-us/library/2b2h26kx.aspx
Hopefully someone who knows this better than me can comment :-)
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2010-01-01 19:50:01 | Re: Win64 warnings about size_t |
Previous Message | Tom Lane | 2010-01-01 19:41:10 | Re: win32 socket definition |