Re: Win64 warnings about size_t

On Fri, Jan 1, 2010 at 18:59, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
>> On Fri, Jan 1, 2010 at 18:47, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> I think MSVC is just complaining about something gcc doesn't.  If you
>>> can disable this specific warning it'd be a good plan.
>
>> Yeah, that should be doable. According to
>> http://msdn.microsoft.com/en-us/library/6kck0s93(VS.80).aspx this
>> warning is only about size_t, and not about the issue in general, so I
>> can just disable C4267 and they should go away.
>
> Sounds good.  The case we do need to look for is any remaining casts
> between pointer and long.  If that's a different warning number then
> we'll be in good shape.

I don't see any such warnings at all. I do see this however:

.\src\backend\utils\mmgr\aset.c(701): warning C4334: '<<' : result
of 32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)
.\src\backend\utils\mmgr\aset.c(705): warning C4334: '<<' : result
of 32-bit shift implicitly converted to 64 bits (was 64-bit shift
intended?)

Perhaps we need some casting there?

Other than that, I see a few more API related warnings that are not
related directly to 32/64-bit. I'l be working on those.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/