| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
| Date: | 2016-04-08 18:29:53 |
| Message-ID: | 9832.1460140193@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Teodor Sigaev <teodor(at)sigaev(dot)ru> writes:
> CREATE INDEX ... INCLUDING (column[, ...])
Buildfarm members that don't like // comments are dying on this bit
in tuplesort.c:
state->nKeys = IndexRelationGetNumberOfKeyAttributes(indexRel); //FIXME
I assume that the problem here is larger than just failure to adhere to
C89 comment style. Was this patch really ready to commit? I'm not very
happy that such a large patch went from "Needs review" to "Committed" in
the blink of an eye on the very last commitfest day ... and artifacts like
this aren't doing anything to increase my confidence in it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-08 18:31:26 | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
| Previous Message | Magnus Hagander | 2016-04-08 18:29:20 | pgsql: Add authentication parameters compat_realm and upn_usename for S |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-08 18:31:26 | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
| Previous Message | Magnus Hagander | 2016-04-08 18:29:46 | Re: [HACKERS] BUG #13854: SSPI authentication failure: wrong realm name used |