| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Andrey M(dot) Borodin" <x4mmm(at)yandex-team(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Amul Sul <sulamul(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: new heapcheck contrib module |
| Date: | 2020-10-08 01:01:24 |
| Message-ID: | 98265AA9-7BDC-4708-9348-CC1B173BBE1D@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 5, 2020, at 5:24 PM, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>
> There remain a few open issues and/or things I did not implement:
>
> - This version follows Robert's suggestion of using pg_class_aclcheck() to check that the caller has permission to select from the table being checked. This is inconsistent with the btree checking logic, which does no such check. These two approaches should be reconciled, but there was apparently no agreement on this issue.
This next version, attached, has the acl checking and associated documentation changes split out into patch 0005, making it easier to review in isolation from the rest of the patch series.
Independently of acl considerations, this version also has some verbiage changes in 0004, in response to Andrey's review upthread.
| Attachment | Content-Type | Size |
|---|---|---|
| v18-0001-Adding-function-verify_heapam-to-amcheck-module.patch | application/octet-stream | 87.4 KB |
| v18-0002-Adding-contrib-module-pg_amcheck.patch | application/octet-stream | 84.9 KB |
| v18-0003-Creating-non-throwing-interface-to-clog-and-slru.patch | application/octet-stream | 21.8 KB |
| v18-0004-Using-non-throwing-clog-interface-from-amcheck.patch | application/octet-stream | 10.8 KB |
| v18-0005-Adding-ACL-checks-for-verify_heapam.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2020-10-08 01:01:38 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | James Coleman | 2020-10-08 00:38:34 | Re: enable_incremental_sort changes query behavior |