| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: behaviour change - default_tablesapce + partition table |
| Date: | 2019-05-20 04:45:10 |
| Message-ID: | 9811f5f3-36d2-39c0-9520-e4c3573d151f@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019/05/20 13:42, Rushabh Lathia wrote:
> On Fri, May 17, 2019 at 10:30 AM Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
>> Why not change it like this instead:
>>
>> @@ -681,7 +681,8 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid
>> ownerId,
>> Assert(list_length(inheritOids) == 1);
>> tablespaceId = get_rel_tablespace(linitial_oid(inheritOids));
>> }
>> - else
>> +
>> + if (!OidIsValid(tablespaceId))
>> tablespaceId =
>> GetDefaultTablespace(stmt->relation->relpersistence,
>> partitioned);
>
> Yes, sure we can do that. Here is the patch for the same.
Thanks Rushabh.
Regards,
Amit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akim Demaille | 2019-05-20 04:45:56 | Re: Remove useless associativity/precedence from parsers |
| Previous Message | Rushabh Lathia | 2019-05-20 04:42:40 | Re: behaviour change - default_tablesapce + partition table |