| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | "tsunakawa(dot)takay(at)fujitsu(dot)com" <tsunakawa(dot)takay(at)fujitsu(dot)com> |
| Cc: | 'Tomas Vondra' <tomas(dot)vondra(at)2ndquadrant(dot)com>, "Andrey V(dot) Lepikhov" <a(dot)lepikhov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: postgres_fdw insert batching |
| Date: | 2021-01-12 02:06:29 |
| Message-ID: | 9808f343-410e-4441-9a10-42e14a1c6436@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Attached is a v6 of this patch, rebased to current master and with some
minor improvements (mostly comments and renaming the "end" struct field
to "values_end" which I think is more descriptive).
The one thing that keeps bugging me is convert_prep_stmt_params - it
dies the right thing, but the code is somewhat confusing.
AFAICS the discussions about making this use COPY and/or libpq
pipelining (neither of which is committed yet) ended with the conclusion
that those changes are somewhat independent, and that it's worth getting
this committed in the current form. Barring objections, I'll push this
within the next couple days.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Add-bulk-insert-for-foreign-tables-v6.patch | text/x-patch | 49.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2021-01-12 02:09:00 | Re: [PATCH] Feature improvement for CLOSE, FETCH, MOVE tab completion |
| Previous Message | Tatsuro Yamada | 2021-01-12 01:57:33 | Re: list of extended statistics on psql |