Re: pgsql: Add TAP tests for pg_verify_checksums

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add TAP tests for pg_verify_checksums
Date: 2018-10-12 21:14:52
Message-ID: 97ce0d10-9105-940c-f843-b9c0b6de4941@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 10/11/2018 08:17 PM, Michael Paquier wrote:
> Add TAP tests for pg_verify_checksums
>
> All options available in the utility get coverage:
> - Tests with disabled page checksums.
> - Tests with enabled test checksums.
> - Emulation of corruption and broken checksums with a full scan and
> single relfilenode scan.
>
> This patch has been contributed mainly by Michael Banck and Magnus
> Hagander with things presented on various threads, and I have gathered
> all the contents into a single patch.
>
> Author: Michael Banck, Magnus Hagander, Michael Paquier
> Reviewed-by: Peter Eisentraut
> Discussion: https://postgr.es/m/20181005012645.GE1629@paquier.xyz

We have some failures here on Windows. I suspect we might need to do a
little more surgery like was done in commit
efd7f8e36553cd32e445061cbbc80d32028f4248

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2018-10-12 21:46:17 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Tom Lane 2018-10-12 18:49:48 pgsql: Back-patch addition of the ALLOCSET_FOO_SIZES macros.

Browse pgsql-hackers by date

  From Date Subject
Next Message Bossart, Nathan 2018-10-12 21:14:57 Re: Maximum password length
Previous Message Isaac Morland 2018-10-12 21:04:00 Re: Maximum password length