Re: renaming ExecStoreWhateverTuple

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: renaming ExecStoreWhateverTuple
Date: 2019-03-25 16:45:36
Message-ID: 9747.1553532336@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2019-03-25 12:33:38 -0400, Tom Lane wrote:
>> I don't think it's wise to think of these things as just "slots";
>> that name is way too generic. They are "tuple slots", and so that
>> word has to stay in the relevant function names.

> Hm. But we already have slot_{getsomeattrs, getallattrs, attisnull,
> getattr, getsysattr}. But perhaps the att in there is enough addiitional
> information?

I don't claim to be entirely innocent in this matter ;-)

If we're going to rename stuff in this area without concern for avoiding
inessential code churn, then those are valid targets as well.

BTW, maybe it's worth drawing a naming distinction between
slot-type-specific and slot-type-independent functions?
(I assume there are still some of the latter.)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2019-03-25 16:53:48 Re: monitoring CREATE INDEX [CONCURRENTLY]
Previous Message Andres Freund 2019-03-25 16:36:56 Re: renaming ExecStoreWhateverTuple