| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD |
| Date: | 2019-01-22 16:44:57 |
| Message-ID: | 9718.1548175497@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>>> Here is a POC which defines an internal interface for a PRNG, and use it
>>> within pgbench, with several possible implementations which default to
>>> rand48.
>> I seriously dislike this patch. pgbench's random support is quite
>> overengineered already IMO, and this proposes to add a whole batch of
>> new code and new APIs to fix a very small bug.
> My intention is rather to discuss postgres' PRNG, in passing. Full success
> on this point:-)
Our immediate problem is to fix a portability failure, which we need to
back-patch into at least one released branch, ergo conservatism is
warranted. I had in mind something more like the attached.
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| dont-use-srandom-in-pgbench-1.patch | text/x-diff | 4.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-01-22 17:12:29 | Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD |
| Previous Message | Fabien COELHO | 2019-01-22 16:19:11 | Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD |