Re: DROP SUBSCRIPTION and ROLLBACK

From: Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DROP SUBSCRIPTION and ROLLBACK
Date: 2017-03-03 18:58:12
Message-ID: 970d8f4c-83a5-4411-8574-0f24f51a1e4e@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23/02/17 08:24, Masahiko Sawada wrote:
> Attached updated version patches. Please review these.
>

This version looks good to me, I'd only change the

> + PreventTransactionChain(isTopLevel, "CREATE SUBSCRIPTION CREATE SLOT");

to "CREATE SUBSCRIPTION ... CREATE SLOT" as that's afaik how we do it
for other commands (and same with DROP).

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Meskes 2017-03-03 19:11:32 Re: [HACKERS] Two phase commit in ECPG
Previous Message Adam Brightwell 2017-03-03 18:44:13 Re: RADIUS fallback servers