Re: Remove warning about const qualifier

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Remove warning about const qualifier
Date: 2007-04-16 19:09:38
Message-ID: 9702.1176750578@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Kris Jurka <books(at)ejurka(dot)com> writes:
> I was testing a gcc 4.3 snapshot from 3/26/07. It also complains
> hba.c:1199: warning: array subscript is below array bounds
> Which looks pretty bogus to me.

I agree.

> And then the following which may be
> valid, but wasn't something I was concerned about at this time.

> tuplesort.c: In function 'comparetup_heap':
> tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
> --param large-stack-frame-growth limit reached
> tuplesort.c:2175: warning: called from here

We've got -Winline turned on mainly as a means of finding out whether
inlining happens or not. I think it's OK to ignore this unless it
happens all over the place.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Stefan Huehner 2007-04-16 19:31:39 Re: Remove warning about const qualifier
Previous Message Kris Jurka 2007-04-16 19:04:38 Re: Remove warning about const qualifier