| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some pg_dump query code simplification |
| Date: | 2018-08-29 14:54:47 |
| Message-ID: | 9700dff7-f05a-9129-09ab-a9be54903d6b@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 28/08/2018 23:43, Tom Lane wrote:
> I think I had this discussion already with somebody, but ... I do not
> like this style at all:
>
> tbinfo->attidentity[j] = (i_attidentity >= 0 ? *(PQgetvalue(res, j, i_attidentity)) : '\0');
OK, updated patch attached. If the updated style is acceptable, I'll
start running more extensive tests against the older branches.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-pg_dump-Reorganize-getTableAttrs.patch | text/plain | 10.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-08-29 15:30:27 | Re: buildfarm: could not read block 3 in file "base/16384/2662": read only 0 of 8192 bytes |
| Previous Message | Alvaro Herrera | 2018-08-29 14:45:09 | Re: Removing useless \. at the end of copy in pgbench |