Re: Questionable ping logic in LogicalRepApplyLoop

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Petr Jelinek <petr(at)2ndquadrant(dot)com>
Subject: Re: Questionable ping logic in LogicalRepApplyLoop
Date: 2020-09-04 21:41:11
Message-ID: 968097.1599255671@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> ... oh look! commit 3f60f690fac1 moved last_recv_timestamp without
> realizing that ping_sent had to get the same treatment.

Hah, I wondered if something like that had happened, but I didn't
get around to excavating in the git history yet. Thanks for doing so.

Will push a fix later.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2020-09-04 21:45:10 Re: A micro-optimisation for walkdir()
Previous Message Tom Lane 2020-09-04 21:39:34 Re: A micro-optimisation for walkdir()