Re: Anti-critical-section assertion failure in mcxt.c reached by walsender

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: Anti-critical-section assertion failure in mcxt.c reached by walsender
Date: 2021-05-07 04:53:34
Message-ID: 9670.1620363214@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> On Fri, May 7, 2021 at 1:43 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> The interesting part of this is frame 6, which points here:

> Oh, and I see that 13 has 9989d37d "Remove XLogFileNameP() from the
> tree" to fix this exact problem.

Hah, so that maybe explains why thorntail has only shown this in
the v12 branch. Should we consider back-patching that?

The more general issue of how to detect, or else make safe,
pallocs in critical error reports remains. But I bet any answer
we think of for that will not be back-patchable. So back-patching
a localized fix for the specific bug we know of might be worth doing.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2021-05-07 05:14:16 Re: Implementing Incremental View Maintenance
Previous Message Thomas Munro 2021-05-07 04:42:46 Re: Anti-critical-section assertion failure in mcxt.c reached by walsender