Re: Allow GUC settings in CREATE SUBSCRIPTION CONNECTION to take effect

Hello Fujii-san,

06.01.2026 05:02, Fujii Masao wrote:
> On Thu, Dec 25, 2025 at 4:00 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> OK, I've updated the 0002 patch accordingly.
> I've pushed the patches. Thanks all!

Buildfarm animal sungazer has revealed a test defect coined with 5f13999aa
[1]:
#   Failed test 'log_statement_stats in CONNECTION string had effect on publisher's walsender'
#   at t/001_rep_changes.pl line 460.
#                   ''
#     doesn't match '(?^:QUERY STATISTICS)'
# Looks like you failed 1 test of 37.
[11:37:37] t/001_rep_changes.pl ...............
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/37 subtests

That is, it managed to read empty log contents here:
# Check that the expected QUERY STATISTICS message appears,
# which shows that log_statement_stats=on from the CONNECTION string
# was correctly passed through to and honored by the walsender.
$logfile = slurp_file($node_publisher->logfile, $log_location);

I believe that's because $log_location is set above for the other log file:
my $log_location = -s $node_subscriber->logfile;

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sungazer&dt=2026-01-31%2005%3A35%3A43

Best regards,
Alexander