Re: New GUC to sample log queries

From: Sergei Kornilov <sk(at)zsrv(dot)org>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Adrien Nayrat <adrien(dot)nayrat(at)anayrat(dot)info>
Cc: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, "vik(dot)fearing(at)2ndquadrant(dot)com" <vik(dot)fearing(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: New GUC to sample log queries
Date: 2018-11-30 11:04:46
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


I can not build current HEAD cleanly. I got warning:

> postgres.c: In function ‘check_log_duration’:
> postgres.c:2254:17: warning: ‘in_sample’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> if ((exceeded && in_sample) || log_duration)

Should not we have such change?

> - bool in_sample;
> + bool in_sample = false;

thank you!

regards, Sergei

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Arthur Zakirov 2018-11-30 11:18:04 Re: Add extension options to control TAP and isolation tests
Previous Message Etsuro Fujita 2018-11-30 10:55:58 Re: de-deduplicate code in DML execution hooks in postgres_fdw